Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update warnings module and reduce pgi optimization #223

Merged
merged 2 commits into from
Sep 22, 2018

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Sep 21, 2018

Update the warnings module to make it more thread-safe. Reduce the pgi optimization consistent with recent CICE changes.

  • Developer(s): tcraig

  • Are the code changes bit for bit, different at roundoff level, or more substantial? bit-for-bit except for pgi.

  • Is the documentation being updated with this PR? (Y/N) N
    If not, does the documentation need to be updated separately at a later time? (Y/N) N

  • Other Relevant Details:

Am getting intermittent recursive I/O runtime errors in the warnings package in CICE. Not clear why that is but suspect it might be threads competing in the write phase of the warnings package. This might or might not fix it, but it does improve the implementation in any case.

Reduced the pgi optimization. O2 was giving reproducibility issues in CICE, that was reduced to O, so we're doing the same here.

Icepack test results are here, https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks, hash d4d68f1. CICE tests are being carried out now.

@apcraig
Copy link
Contributor Author

apcraig commented Sep 22, 2018

I tested this in CICE and things are fine. Results are https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks hash 3b78bd. The cray results are not bit-for-bit due to an earlier change in Icepack, adding "dhi = c0, dhs = c0" in icepack_therm_vertical.F90. Not sure why this only affected cray and not other compilers. I have confirmed this. I have tested on 5 compilers and all the failures are understood and not a problem as far as I can tell.

@eclare108213 eclare108213 merged commit 49a1cc9 into CICE-Consortium:master Sep 22, 2018
lettie-roach pushed a commit to lettie-roach/Icepack that referenced this pull request Oct 18, 2022
update icepack and fix some scripting issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants