update warnings module and reduce pgi optimization #223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the warnings module to make it more thread-safe. Reduce the pgi optimization consistent with recent CICE changes.
Developer(s): tcraig
Are the code changes bit for bit, different at roundoff level, or more substantial? bit-for-bit except for pgi.
Is the documentation being updated with this PR? (Y/N) N
If not, does the documentation need to be updated separately at a later time? (Y/N) N
Other Relevant Details:
Am getting intermittent recursive I/O runtime errors in the warnings package in CICE. Not clear why that is but suspect it might be threads competing in the write phase of the warnings package. This might or might not fix it, but it does improve the implementation in any case.
Reduced the pgi optimization. O2 was giving reproducibility issues in CICE, that was reduced to O, so we're doing the same here.
Icepack test results are here, https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks, hash d4d68f1. CICE tests are being carried out now.