Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to link against an installed libfaust. Fixes #12. #14

Closed
wants to merge 1 commit into from

Conversation

agraef
Copy link
Contributor

@agraef agraef commented Aug 5, 2020

No description provided.

@agraef
Copy link
Contributor Author

agraef commented Aug 5, 2020

Note that this will link against the shared library if present, as gcc will prefer that. @pierreguillot, @dvzrv, if you both have a strong preference for linking libfaust statically, I can change it, but it will add a lot of complication and might not work on some systems, because there's no easy way to detect the location of the static library on all platforms.

@agraef
Copy link
Contributor Author

agraef commented Aug 5, 2020

@pierreguillot, I guess that you still need more time to review this, so I'll just go ahead and rebase #13 on this PR now, so that we can then close this one and have the entire shebang in #13. This will let me continue while you take your time. I actually have all this ready, and I'd like to get this out of the door asap, so that I can continue to work on more interesting things. ;-)

@agraef
Copy link
Contributor Author

agraef commented Aug 5, 2020

Added this PR to #13, so closing this one.

@agraef agraef closed this Aug 5, 2020
@agraef agraef deleted the installed-libfaust branch August 5, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant