Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library uses the root logger #7

Closed
simonsben opened this issue May 2, 2022 · 2 comments
Closed

Library uses the root logger #7

simonsben opened this issue May 2, 2022 · 2 comments

Comments

@simonsben
Copy link
Contributor

Using the root logger makes the source of logs hard to identify and leads to difficulty when being used as part of a larger project. To solve this we should use logging.getLogger to initialize the logger as something identifying, ex. pypdns
@simonsben simonsben mentioned this issue May 2, 2022
Merged
@simonsben
Copy link
Contributor Author

Nice

@adulau
Copy link
Member

adulau commented May 2, 2022

Thank you. If you see other stuff to improve, feel free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adulau @simonsben