Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 code on website leads to internal error #66

Closed
FafnerKeyZee opened this issue Feb 13, 2020 · 1 comment
Closed

404 code on website leads to internal error #66

FafnerKeyZee opened this issue Feb 13, 2020 · 1 comment
Assignees
@Rafiot

Comments

@FafnerKeyZee
Copy link
Contributor

Hey,

With the latest version, if I submit a website with a 404 code return, lookyloo is crashing with an internal error 500.
logs are there: https://pastebin.com/Yh9nJ7gs
But when calling it directly from command line:

curl 'http://localhost:8050/render.html?url=http://domain/page.html&timeout=10&wait=0.5'
<!DOCTYPE html PUBLIC "-//IETF//DTD HTML 2.0//EN"><html><head>
<title>404 Not Found</title>
</head><body>
<h1>Not Found</h1>
<p>The requested URL /404.html was not found on this server.</p>

</body></html>

har, png and html keys should exist...

best regards,
@Rafiot Rafiot self-assigned this Feb 13, 2020
Rafiot added a commit to Lookyloo/ScrapySplashWrapper that referenced this issue Feb 16, 2020
@Rafiot
fix: Properly handle HTTP errors
461e736 
Related: Lookyloo/lookyloo#66
@Rafiot Rafiot closed this as completed in 7d2f501 Feb 16, 2020
@Rafiot
Copy link
Member

Rafiot commented Feb 16, 2020

That should be properly handled now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rafiot Rafiot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rafiot @FafnerKeyZee