Fixed bug in weighted means per Simon. #24
Conversation
| RealMatrix resid = new BlockRealMatrix(n, 1); | ||
| for (int i = 0; i < n; i++) { | ||
| resid.setEntry(i, 0, y[i] - (slope * x[i]) - intercept); | ||
| } | ||
|
|
||
| RealMatrix residT = resid.transpose(); | ||
| RealMatrix mM = residT.multiply(omega).multiply(resid); | ||
| RealMatrix mM = residT.multiply(invOmega).multiply(resid); |
There was a problem hiding this comment.
yes - a typo in the Wiki had omega instead of invOmega
On Sun, Jul 17, 2016 at 7:01 PM, John Zeringue notifications@github.com
wrote:
In
src/main/java/org/cirdles/calamari/algorithms/WeightedMeanCalculators.java
https://github.com/bowring/Calamari/pull/24#discussion_r71091606:RealMatrix resid = new BlockRealMatrix(n, 1); for (int i = 0; i < n; i++) { resid.setEntry(i, 0, y[i] - (slope * x[i]) - intercept); } RealMatrix residT = resid.transpose();
RealMatrix mM = residT.multiply(omega).multiply(resid);RealMatrix mM = residT.multiply(invOmega).multiply(resid);Is this the fix?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/bowring/Calamari/pull/24/files/055428b7ee700f8f233dde977d14468543bab4d3..ebd7d1f831863f6c3465da01aaf7e0d97f2ba7cc#r71091606,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABCtYz9H5LcYz7T5HcLt6gm07d5cyWhrks5qWrRIgaJpZM4JOQe3
.
Jim Bowring
C. Richard Crosby Distinguished Teaching Co-Chair
Principal Investigator, www.CIRDLES.org, www.github.com/cirdles
GitHub: https://github.com/bowring
Computer Science
College of Charleston
66 George Street
Charleston, SC 29424
Google Voice: 843.608.1399 (preferred)
Google Email: bowring@gmail.com
Office:
Harbor Walk East (360 Concord Street) Room 308
843.953.0805
http://stono.cs.cofc.edu/~bowring/
bowringj@cofc.edu
R. Buckminster Fuller (1972):
If humanity is to survive aboard our planet, it must become universally
literate and preoccupied with inherently cooperative Comprehensive
Anticipatory Design Science in which every human is concerned with
accomplishing the comfortably sustainable well-faring of all other humans.
Updated and reenabled the expected reports to match the output of CIRDLES#24.
Also set default value of minIndex assigned to an isotopicRatio as -2 to serve as a logic check in Step 3.