Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HashNet does not update the beta value properly, resulting in the beta value staying as its original (default) value for both training and testing #6

Closed
thaiminhpv opened this issue Aug 4, 2022 · 0 comments
Closed

HashNet does not update the beta value properly, resulting in the beta value staying as its original (default) value for both training and testing #6

thaiminhpv opened this issue Aug 4, 2022 · 0 comments

Comments

@thaiminhpv
Copy link
Contributor

Great work! 馃帀馃憤

I've found a bug that the value of beta of HashNet isn't updated, resulting in the beta value staying as its original (default) value for both training and testing.

cisip-FIRe/scripts/train_general.py

Line 121 in 6ff37f7

loss_param['loss_param']['beta'] = (ep // step_continuation + 1) ** 0.5

as loss_param['loss_param']['beta'] only updates the params config, but doesn't make changes to running HashNet's beta value.
@thaiminhpv thaiminhpv mentioned this issue Aug 4, 2022
Merged
jiuntian added a commit that referenced this issue Aug 4, 2022
@jiuntian
Merge pull request #7 from thaiminhpv/main
0decdef 
Fix issue #6: HashNet does not update the beta value properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thaiminhpv