Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to remove repeated code #5

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Refactor to remove repeated code #5

merged 1 commit into from
Aug 15, 2018

Conversation

mapingo
Copy link
Contributor

@mapingo mapingo commented Sep 19, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.0%) to 75.714% when pulling e67b2ed on refactor-remove-repeated-code into c26f368 on master.

@mapingo mapingo force-pushed the refactor-remove-repeated-code branch from e67b2ed to 82ca203 Compare September 19, 2017 10:46
@coveralls
Copy link

Coverage Status

Coverage increased (+1.9%) to 73.611% when pulling 82ca203 on refactor-remove-repeated-code into c26f368 on master.

@mapingo mapingo force-pushed the refactor-remove-repeated-code branch from 82ca203 to 96362e7 Compare September 19, 2017 11:20
@coveralls
Copy link

coveralls commented Sep 19, 2017 •
edited
Loading

Coverage Status

Coverage increased (+9.5%) to 83.333% when pulling 62110c2 on refactor-remove-repeated-code into a0f21dd on master.

purple52
purple52 previously requested changes Sep 19, 2017
View reviewed changes
Copy link
Contributor

@purple52 purple52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but waiting until 2.0.1 is released before merging to master

@mapingo mapingo force-pushed the refactor-remove-repeated-code branch from 96362e7 to 6fe5a94 Compare August 15, 2018 15:31
@purple52 purple52 dismissed their stale review August 15, 2018 15:38

2.0.1 was merged to master a very long time ago

@mapingo mapingo force-pushed the refactor-remove-repeated-code branch from 6fe5a94 to 62110c2 Compare August 15, 2018 15:39
@bdellegrazie bdellegrazie merged commit f73dceb into master Aug 15, 2018
@bdellegrazie bdellegrazie deleted the refactor-remove-repeated-code branch August 15, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdellegrazie bdellegrazie bdellegrazie approved these changes

@purple52 purple52 purple52 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mapingo @coveralls @bdellegrazie @purple52