Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to determine topic names #9

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

bdellegrazie
Copy link
Contributor

No description provided.

@bdellegrazie bdellegrazie self-assigned this Aug 15, 2018
@cjs-common-platform-ci
Copy link
Member

SonarQube analysis reported 1 issue

  • MAJOR 1 major

Watch the comments in this conversation to review them.

@@ -12,4 +12,6 @@
long reprocess(final String host, final String port, final String brokerName, final String destinationName, final Iterator<String> msgIds) throws Exception;

String[] queueNames(final String host, final String port, final String brokerName) throws Exception;

String[] topicNames(final String host, final String port, final String brokerName) throws Exception;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Define and throw a dedicated exception instead of using a generic one. rule

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 73.837% when pulling 95d8468 on feature-topic-names into 473ed73 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants