Add constant for mbean operation

CJSCommonPlatform · Apr 12, 2019 · b1a12ae · b1a12ae
1 parent e4254fd
commit b1a12ae
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 10 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -17,21 +17,22 @@ before_script:
 - psql -c "CREATE USER framework WITH PASSWORD 'framework';" -U postgres
 addons:
   postgresql: '9.5'
-#  sonarcloud:
-#    organization: cjscommonplatform
-#    token:
-#      secure: MPrE0HzubH6Of0OeMlYuB5vEZNVfJE8wZG/iWdVmNHBVWWodEP4sO8s1GggKQk5rrHiSlVXs+G7OIM4X6Kg2HnjUj05G28IpirtkDnCLvIcSqAZxecO21tIBYwHn/mCdihHQOPjA8RFjc8+TSsRDNipeR3QvOzf6g5XZtOV/Ew+p5VoirIbI9jOO/qdOzHuQjZhARmI7HXqEmpkXJiObfyT5uJvO047lSbKA48VLWSfv2zFl5+8uymT+0g8fHPm9JWTNn7VLyKQQ4en7Cr9NC03Ahk8rXybB0qOrHj3fewtUGBp3pCa8bU6XaMFzSNHixueUG2mxxxI9ROB7nz+19CSOGafXZsygjDqPeT8D1wHHGGBmc90WQE3JhU9YFMXKnx5/a8OJyIAGRUE81wt3FsJUu+OvIHdQEOlM7geWYv6P52VbgmJSSvMgRnzNE3seq0LSsFxQXAQmAmDLWwWz0t2wbzO8dUmmU4jn5xoqSe2RBENaD1vDG37rvi8aGrr+Xg2005/8yIvlr+7ZZbeiHdYXqzbiDdYQyGjr8FaJLI3WPBtCRhsvJBgdQhuMFI/V44ntwAP6CzOty9Gfldlp+ybaY9UcFSKbGxBcrHPJfsS2ajgPUjW1K8KBFc7IKfy/XWhBsWOEHgVb2n4AZSV/nFTpK4HwpvHid0bEHcyTpk8=
-    github_token:
-      secure: CZAEIt+cZXQKh/q0gAyTGi2ypJA2OHRp2gKD/pcvIkR8CzmUe+qlV4tI0DV81dsK3O68rK9AzmnbdJH95zEds+MHrsLmOX6+pCjoH4z6lDcaxFE6put/UOqbHfgC5XDs+0zhb1XKcf6tnPgsYy9s2sCXVQL4DFHOuBVMZ4IgMEXxVzlAk50qthBX4QJBn5Wvui1oOMLR+lJFaS4Lu4V11TihHzszpTyQdg0ME6bN+pskrcPInNIuuSfr7928E8MzWpxmj9o0MqyhXwRH9QWE3szG3FSmFVGYfyDQ1lXscDmb0I5wUxMGP6+CfwIDPXbOtyft4ztc29SYw0NU1DwPzF+8/jZxs3od3NANb0iObmUSdLEiX+re/DHzP3cMn28X/5s8ps4BGcLMg5c9KSdXVtZB48a+7Ez2lbxpBezHZLLADnQ+zNb9B+KdkA1Lo9BFu7zvlHaO9kXjxJgWs2DOOzW0zzeBDk+ysG80GBFPJBCfHxaXxQsKNGfZxnBocGDCGwDSvfs9faDnXu7u0KLMmJBabx/HtbR8qJkNUMwA+iVPkNM2RyVfEPNZHwZfu2wB+Oo9XVX0nM4sxvbRkir2RqulafK7ZWOFLl5tmmdISj1LZ/d8mVTBeA+BFe8AsfO9b+d6CBQbVGGq8Wn4i84khbFCIH30/wDMiURU4XQT+5Q=
+  sonarcloud:
+    organization: cjscommonplatform
+    token:
+      secure: MPrE0HzubH6Of0OeMlYuB5vEZNVfJE8wZG/iWdVmNHBVWWodEP4sO8s1GggKQk5rrHiSlVXs+G7OIM4X6Kg2HnjUj05G28IpirtkDnCLvIcSqAZxecO21tIBYwHn/mCdihHQOPjA8RFjc8+TSsRDNipeR3QvOzf6g5XZtOV/Ew+p5VoirIbI9jOO/qdOzHuQjZhARmI7HXqEmpkXJiObfyT5uJvO047lSbKA48VLWSfv2zFl5+8uymT+0g8fHPm9JWTNn7VLyKQQ4en7Cr9NC03Ahk8rXybB0qOrHj3fewtUGBp3pCa8bU6XaMFzSNHixueUG2mxxxI9ROB7nz+19CSOGafXZsygjDqPeT8D1wHHGGBmc90WQE3JhU9YFMXKnx5/a8OJyIAGRUE81wt3FsJUu+OvIHdQEOlM7geWYv6P52VbgmJSSvMgRnzNE3seq0LSsFxQXAQmAmDLWwWz0t2wbzO8dUmmU4jn5xoqSe2RBENaD1vDG37rvi8aGrr+Xg2005/8yIvlr+7ZZbeiHdYXqzbiDdYQyGjr8FaJLI3WPBtCRhsvJBgdQhuMFI/V44ntwAP6CzOty9Gfldlp+ybaY9UcFSKbGxBcrHPJfsS2ajgPUjW1K8KBFc7IKfy/XWhBsWOEHgVb2n4AZSV/nFTpK4HwpvHid0bEHcyTpk8=
+#    github_token:
+#      secure: CZAEIt+cZXQKh/q0gAyTGi2ypJA2OHRp2gKD/pcvIkR8CzmUe+qlV4tI0DV81dsK3O68rK9AzmnbdJH95zEds+MHrsLmOX6+pCjoH4z6lDcaxFE6put/UOqbHfgC5XDs+0zhb1XKcf6tnPgsYy9s2sCXVQL4DFHOuBVMZ4IgMEXxVzlAk50qthBX4QJBn5Wvui1oOMLR+lJFaS4Lu4V11TihHzszpTyQdg0ME6bN+pskrcPInNIuuSfr7928E8MzWpxmj9o0MqyhXwRH9QWE3szG3FSmFVGYfyDQ1lXscDmb0I5wUxMGP6+CfwIDPXbOtyft4ztc29SYw0NU1DwPzF+8/jZxs3od3NANb0iObmUSdLEiX+re/DHzP3cMn28X/5s8ps4BGcLMg5c9KSdXVtZB48a+7Ez2lbxpBezHZLLADnQ+zNb9B+KdkA1Lo9BFu7zvlHaO9kXjxJgWs2DOOzW0zzeBDk+ysG80GBFPJBCfHxaXxQsKNGfZxnBocGDCGwDSvfs9faDnXu7u0KLMmJBabx/HtbR8qJkNUMwA+iVPkNM2RyVfEPNZHwZfu2wB+Oo9XVX0nM4sxvbRkir2RqulafK7ZWOFLl5tmmdISj1LZ/d8mVTBeA+BFe8AsfO9b+d6CBQbVGGq8Wn4i84khbFCIH30/wDMiURU4XQT+5Q=
 before_install:
 - git clone https://github.com/CJSCommonPlatform/travis-settings.git target/travis-settings
 - ln -sfT ${PWD}/target/travis-settings/settings.xml ${HOME}/.m2/settings.xml
 - ln -sfT ${PWD}/target/travis-settings/mvnw mvnw
 - ln -sft ${PWD} ${PWD}/target/travis-settings/.mvn
 install: "${PWD}/target/travis-settings/java/install.sh -e -q -DexcludeGroupIds=uk.gov.justice.service,uk.gov.justice.services"
-#script: "${PWD}/target/travis-settings/java/script-install.sh coveralls:report sonar:sonar"
+script:
+  "${PWD}/target/travis-settings/java/script-install.sh coveralls:report sonar:sonar"
+#  - mvn clean org.jacoco:jacoco-maven-plugin:prepare-agent install sonar:sonar
 
-script: "${PWD}/target/travis-settings/java/script-install.sh coveralls:report"
 after_success: "${PWD}/target/travis-settings/java/after_success.sh"
 notifications:
   slack:

diff --git a/...ain/java/uk/gov/justice/services/example/cakeshop/event/listener/RecipeEventListener.java b/...ain/java/uk/gov/justice/services/example/cakeshop/event/listener/RecipeEventListener.java
@@ -99,4 +99,10 @@ public void recipePhotographAdded(final JsonEnvelope event) {
         recipeRepository.save(recipe);
     }
 
+    public void dodgyMethod() {
+        String DODGYVARIABLE = "dodgy";
+        LOGGER.info("dodgy: " + DODGYVARIABLE);
+        System.out.println("Invoke dodgy method");
+        LOGGER.info("=============> Inside add-recipe Event Listener. RecipeId: "+ DODGYVARIABLE);
+    }
 }
diff --git a/...ce/example-it/src/test/java/uk/gov/justice/services/example/cakeshop/it/ShutteringIT.java b/...ce/example-it/src/test/java/uk/gov/justice/services/example/cakeshop/it/ShutteringIT.java
@@ -49,6 +49,7 @@ public class ShutteringIT {
     private static final Logger logger = getLogger(ShutteringIT.class);
     private static final String MARBLE_CAKE = "Marble cake";
     private static final String CARROT_CAKE = "Carrot cake";
+    private static final String MBEAN_OPERATION_SHUTTERING = "shuttering";
 
     private final EventFactory eventFactory = new EventFactory();
 
@@ -81,6 +82,9 @@ public void cleanup() throws MalformedObjectNameException, IntrospectionExceptio
 
     @Test
     public void shouldNotReturnRecipesAfterShuttering() throws MalformedObjectNameException, IntrospectionException, ReflectionException, InstanceNotFoundException, IOException {
+
+        dodgyMethod();
+
         //invoke shuttering
         invokeShuttering(true);
 
@@ -150,7 +154,7 @@ private void invokeShuttering(final boolean isShutteringRequired) throws IOExcep
 
             final MBeanServerConnection connection = jmxConnector.getMBeanServerConnection();
 
-            final ObjectName objectName = new ObjectName("shuttering", "type", Shuttering.class.getSimpleName());
+            final ObjectName objectName = new ObjectName(MBEAN_OPERATION_SHUTTERING, "type", Shuttering.class.getSimpleName());
 
             if(isShutteringRequired) {
                 mBeanHelper.getMbeanProxy(connection, objectName, ShutteringMBean.class).doShutteringRequested();
@@ -160,10 +164,24 @@ private void invokeShuttering(final boolean isShutteringRequired) throws IOExcep
         }
     }
 
-    
+
     private String addRecipe(final String cakeName) {
         final String recipeId = randomUUID().toString();
         commandSender.addRecipe(recipeId, cakeName);
         return recipeId;
     }
+
+    public void dodgyMethod() {
+        String DODGYVARIABLE = "dodgy";
+        logger.info("dodgy: " + DODGYVARIABLE);
+        System.out.println("Invoke dodgy method");
+        logger.info("=============> Inside add-recipe Event Listener. RecipeId: "+ DODGYVARIABLE);
+    }
+
+    public void dodgyMethod2() {
+        String DODGYVARIABLE = "dodgy";
+        logger.info("dodgy: " + DODGYVARIABLE);
+        System.out.println("Invoke dodgy method");
+        logger.info("=============> Inside add-recipe Event Listener. RecipeId: "+ DODGYVARIABLE);
+    }
 }