Add Shuttering Implementation #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlzhn
force-pushed
the
add-shuttering-it-implementation
branch
3 times, most recently
from
d6f4025
to
eae2837
Compare
mapingo
suggested changes
Apr 8, 2019
| @@ -16,6 +16,7 @@ | |||
| import static uk.gov.justice.services.example.cakeshop.it.params.CakeShopUris.RECIPES_RESOURCE_QUERY_URI; | |||
| import static uk.gov.justice.services.example.cakeshop.it.params.CakeShopUris.RECIPES_RESOURCE_URI; | |||
|
|
|||
| import org.junit.*; | |||
There was a problem hiding this comment.
the .* import needs changing, maybe the intellij code style is not set
| @@ -9,17 +9,13 @@ | |||
| import static org.hamcrest.core.IsNull.nullValue; | |||
| import static uk.gov.justice.services.example.cakeshop.it.params.CakeShopUris.ORDERS_RESOURCE_URI; | |||
|
|
|||
| import org.junit.*; | |||
There was a problem hiding this comment.
the .* import needs changing
| @@ -10,6 +10,7 @@ | |||
| import static uk.gov.justice.services.example.cakeshop.it.params.CakeShopMediaTypes.CONTEXT_NAME; | |||
| import static uk.gov.justice.services.example.cakeshop.it.params.CakeShopUris.RECIPES_RESOURCE_URI; | |||
|
|
|||
| import org.junit.*; | |||
There was a problem hiding this comment.
the .* import needs changing
| @@ -7,6 +7,7 @@ | |||
| import static org.junit.Assert.assertNull; | |||
| import static uk.gov.justice.services.example.cakeshop.it.params.CakeShopUris.RECIPES_RESOURCE_URI; | |||
|
|
|||
| import org.junit.*; | |||
There was a problem hiding this comment.
the .* import needs changing
| @@ -17,6 +17,7 @@ | |||
| import static uk.gov.justice.services.example.cakeshop.it.params.CakeShopUris.ORDERS_RESOURCE_URI; | |||
| import static uk.gov.justice.services.test.utils.core.matchers.HttpStatusCodeMatcher.isStatus; | |||
|
|
|||
| import org.junit.*; | |||
There was a problem hiding this comment.
the .* import needs changing
| @@ -6,6 +6,7 @@ | |||
| import static org.hamcrest.core.IsCollectionContaining.hasItem; | |||
| import static uk.gov.justice.services.test.utils.core.reflection.ReflectionUtil.setField; | |||
|
|
|||
| import org.junit.*; | |||
There was a problem hiding this comment.
the .* import needs changing
mapingo
suggested changes
Apr 8, 2019
| .assertThat("$.recipes[?(@.id=='" + recipeId + "')].name", hasItem(recipeName)) | ||
| .assertThat("$.recipes[?(@.id=='" + recipeId2 + "')].name", hasItem(recipeName2)); | ||
| } | ||
| else{ |
There was a problem hiding this comment.
"else" looks better if on the same line as the } above it
| if(isShutteringRequired){ | ||
| mBeanHelper.getMbeanProxy(connection, objectName, ShutteringMBean.class).doShutteringRequested(); | ||
| } | ||
| else{ |
There was a problem hiding this comment.
"else" looks better if on the same line as the } above it
wlzhn
force-pushed
the
add-shuttering-it-implementation
branch
5 times, most recently
from
c43d616
to
39e01c9
Compare
wlzhn
force-pushed
the
add-shuttering-it-implementation
branch
from
39e01c9
to
2cbe958
Compare
mapingo
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.