Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up Shuttering IT #23

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Tidy up Shuttering IT #23

merged 1 commit into from
Apr 10, 2019

Conversation

wlzhn
Copy link
Collaborator

@wlzhn wlzhn commented Apr 10, 2019

No description provided.

@wlzhn wlzhn requested a review from BenNzewi April 10, 2019 10:46
@coveralls
Copy link

coveralls commented Apr 10, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 191

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.81%
Totals Coverage Status
Change from base Build 180: 0.0%
Covered Lines: 359
Relevant Lines: 621
💛 - Coveralls

@wlzhn wlzhn force-pushed the update-shuttering-integration-test branch 4 times, most recently from aa9b5e3 to d6e7283 Compare April 10, 2019 13:54
allanmckenzie
allanmckenzie reviewed Apr 10, 2019
View reviewed changes
...rvice/example-it/src/test/java/uk/gov/justice/services/example/cakeshop/it/ShutteringIT.java Outdated

return response;
}

private void invokeShuttering(final boolean isShutteringRequired) throws IOException, MalformedObjectNameException, IntrospectionException, InstanceNotFoundException, ReflectionException {
try(JMXConnector jmxConnector = mBeanHelper.getJMXConnector()){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final

@wlzhn wlzhn force-pushed the update-shuttering-integration-test branch from d6e7283 to 365714f Compare April 10, 2019 14:14
@mapingo mapingo merged commit ce997bb into master Apr 10, 2019
@mapingo mapingo deleted the update-shuttering-integration-test branch April 10, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapingo mapingo mapingo approved these changes

@allanmckenzie allanmckenzie allanmckenzie approved these changes

@BenNzewi BenNzewi Awaiting requested review from BenNzewi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wlzhn @coveralls @mapingo @allanmckenzie