Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unifiedsearch indexer #37

Merged
merged 1 commit into from
May 30, 2019
Merged

Add unifiedsearch indexer #37

merged 1 commit into from
May 30, 2019

Conversation

MartinYSpasov
Copy link
Contributor

No description provided.

@MartinYSpasov MartinYSpasov force-pushed the dev/add-event-indexer branch 2 times, most recently from e22cdc5 to 89ca1de Compare May 30, 2019 09:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 327

  • 24 of 48 (50.0%) changed or added relevant lines in 8 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.8%) to 56.994%
Changes Missing Coverage Covered Lines Changed/Added Lines %
example-context/example-service/example-query/example-query-view/src/main/java/uk/gov/justice/services/example/cakeshop/query/view/request/SearchIndex.java 5 6 83.33%
example-context/example-service/example-query/example-query-view/src/main/java/uk/gov/justice/services/example/cakeshop/query/view/service/IndexService.java 0 3 0.0%
example-context/example-service/example-query/example-query-api/src/main/java/uk/gov/justice/services/example/cakeshop/query/api/request/SearchIndex.java 0 6 0.0%
example-context/example-service/example-query/example-query-api/src/main/java/uk/gov/justice/services/example/cakeshop/query/api/response/IndexView.java 0 6 0.0%
example-context/example-persistence/src/main/java/uk/gov/justice/services/example/cakeshop/persistence/entity/Index.java 6 14 42.86%
Files with Coverage Reduction New Missed Lines %
example-context/example-service/example-query/example-query-view/target/generated-sources/uk/gov/justice/api/mapper/ExampleQueryViewActionNameToMediaTypesMapper.java 2 0.0%
example-context/example-service/example-query/example-query-api/target/generated-sources/uk/gov/justice/api/mapper/ExampleQueryApiActionNameToMediaTypesMapper.java 2 0.0%
Totals Coverage Status
Change from base Build 321: -0.8%
Covered Lines: 383
Relevant Lines: 672
💛 - Coveralls

@MartinYSpasov MartinYSpasov force-pushed the dev/add-event-indexer branch 2 times, most recently from d8ebd40 to 2c35863 Compare May 30, 2019 10:54
allanmckenzie
allanmckenzie reviewed May 30, 2019
View reviewed changes
...uery-api/src/main/java/uk/gov/justice/services/example/cakeshop/query/api/IndexQueryApi.java Outdated
public class IndexQueryApi {

@Inject
Requester requester;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be private

allanmckenzie
allanmckenzie reviewed May 30, 2019
View reviewed changes
.../test/java/uk/gov/justice/services/example/cakeshop/query/view/service/IndexServiceTest.java Outdated

when(repository.findBy(indexId)).thenReturn(new Index(indexId, deliveryDate));

IndexView view = service.findIndexBy(indexId.toString());
Copy link
Member

@allanmckenzie allanmckenzie May 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final :-)

allanmckenzie
allanmckenzie reviewed May 30, 2019
View reviewed changes
.../test/java/uk/gov/justice/services/example/cakeshop/query/view/service/IndexServiceTest.java Outdated

when(repository.findBy(any(UUID.class))).thenReturn(null);

IndexView view = service.findIndexBy(UUID.randomUUID().toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final :-)

@allanmckenzie allanmckenzie merged commit 5a302b4 into master May 30, 2019
@allanmckenzie allanmckenzie deleted the dev/add-event-indexer branch October 28, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanmckenzie allanmckenzie allanmckenzie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MartinYSpasov @coveralls @allanmckenzie