Add implementation for updating StreamStatus table with component column #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenNzewi
requested review from
mapingo,
allanmckenzie,
DesMarshall01 and
MartinYSpasov
Pull Request Test Coverage Report for Build 1006
💛 - Coveralls |
mapingo
suggested changes
May 28, 2019
| ps.setObject(2, subscription.getStreamId()); | ||
| ps.setString(3, subscription.getSource()); | ||
| ps.executeUpdate(); | ||
| setPreparedStatementParameters(subscription, ps); |
There was a problem hiding this comment.
I liked this method in-lined better...easier to look at a glance what is happening
MartinYSpasov
approved these changes
May 28, 2019
BenNzewi
force-pushed
the
add-component-name-to-streamstatus-table-and-relevant-implementation
branch
from
b166c12
to
643e6fb
Compare
mapingo
approved these changes
May 28, 2019
BenNzewi
force-pushed
the
add-component-name-to-streamstatus-table-and-relevant-implementation
branch
2 times, most recently
from
e3518b7
to
22b93b8
Compare
BenNzewi
force-pushed
the
add-component-name-to-streamstatus-table-and-relevant-implementation
branch
from
22b93b8
to
b27fb13
Compare
allanmckenzie
approved these changes
May 29, 2019
MartinYSpasov
deleted the
add-component-name-to-streamstatus-table-and-relevant-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.