Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential problem of a transaction failing during catchup causing… #208

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Fix potential problem of a transaction failing during catchup causing… #208

merged 1 commit into from
Jan 6, 2020

Conversation

mapingo
Copy link
Contributor

@mapingo mapingo commented Jan 6, 2020

… catchup to never complete

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1671

  • 33 of 35 (94.29%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 91.146%
Changes Missing Coverage Covered Lines Changed/Added Lines %
event-store-management/event-store-management-core/src/main/java/uk/gov/justice/services/eventstore/management/catchup/state/CatchupError.java 2 4 50.0%
Totals Coverage Status
Change from base Build 1669: 0.05%
Covered Lines: 3109
Relevant Lines: 3411
💛 - Coveralls

@allanmckenzie allanmckenzie merged commit ae5385e into master Jan 6, 2020
@allanmckenzie allanmckenzie deleted the fix-transaction-failing-catchup branch March 5, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanmckenzie allanmckenzie allanmckenzie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mapingo @coveralls @allanmckenzie