Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire CatchupStartedEvent at the correct time to allow for multiple co… #212

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Fire CatchupStartedEvent at the correct time to allow for multiple co… #212

merged 1 commit into from
Jan 21, 2020

Conversation

allanmckenzie
Copy link
Member

…mponent catchups

@coveralls
Copy link

coveralls commented Jan 21, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1703

  • 52 of 55 (94.55%) changed or added relevant lines in 10 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 90.965%
Changes Missing Coverage Covered Lines Changed/Added Lines %
event-store-management/event-store-management-core/src/main/java/uk/gov/justice/services/eventstore/management/catchup/process/CatchupSubscriptionContext.java 3 4 75.0%
event-store-management/event-store-management-core/src/main/java/uk/gov/justice/services/eventstore/management/catchup/process/CatchupInProgress.java 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
event-store-management/event-store-management-core/src/main/java/uk/gov/justice/services/eventstore/management/catchup/process/CatchupInProgress.java 4 46.15%
Totals Coverage Status
Change from base Build 1685: -0.07%
Covered Lines: 3091
Relevant Lines: 3398
💛 - Coveralls

@allanmckenzie allanmckenzie force-pushed the fix-multiple-component-catchup branch 2 times, most recently from f38081b to a744f70 Compare January 21, 2020 11:48
@mapingo mapingo force-pushed the fix-multiple-component-catchup branch from a744f70 to 1a9a527 Compare January 21, 2020 11:57
@sonarcloud
Copy link

sonarcloud bot commented Jan 21, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

55.5% 55.5% Coverage
0.0% 0.0% Duplication

@mapingo mapingo merged commit 0e8bbcc into release-2.4.x Jan 21, 2020
@mapingo mapingo deleted the fix-multiple-component-catchup branch January 21, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapingo mapingo mapingo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@allanmckenzie @coveralls @mapingo