Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick 2.4.x #216

Merged
merged 5 commits into from
Jan 30, 2020
Merged

Cherry pick 2.4.x #216

merged 5 commits into from
Jan 30, 2020

Conversation

allanmckenzie
Copy link
Member

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

79.6% 79.6% Coverage
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1737

  • 67 of 70 (95.71%) changed or added relevant lines in 12 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 91.26%

Changes Missing Coverage Covered Lines Changed/Added Lines %
event-store-management/event-store-management-core/src/main/java/uk/gov/justice/services/eventstore/management/catchup/process/CatchupSubscriptionContext.java 3 4 75.0%
event-store-management/event-store-management-core/src/main/java/uk/gov/justice/services/eventstore/management/catchup/process/CatchupInProgress.java 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
event-store-management/event-store-management-core/src/main/java/uk/gov/justice/services/eventstore/management/catchup/process/CatchupInProgress.java 4 46.15%
Totals Coverage Status
Change from base Build 1672: 0.1%
Covered Lines: 3101
Relevant Lines: 3398

💛 - Coveralls

@mapingo mapingo merged commit 2159bb4 into master Jan 30, 2020
@mapingo mapingo deleted the cherry-pick-2.4.x branch January 30, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants