Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail cleanly if exception occurs while access subscription event source #220

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Fail cleanly if exception occurs while access subscription event source #220

merged 1 commit into from
Mar 4, 2020

Conversation

mapingo
Copy link
Contributor

@mapingo mapingo commented Feb 28, 2020

No description provided.

@coveralls
Copy link

coveralls commented Feb 28, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1759

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 91.223%
Totals Coverage Status
Change from base Build 1753: 0.02%
Covered Lines: 3087
Relevant Lines: 3384
💛 - Coveralls

@mapingo mapingo force-pushed the fix-failure-on-exception-catchup-master branch from 36bc037 to 06ac792 Compare March 2, 2020 11:01
@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@allanmckenzie allanmckenzie merged commit b3af808 into master Mar 4, 2020
@allanmckenzie allanmckenzie deleted the fix-failure-on-exception-catchup-master branch March 5, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanmckenzie allanmckenzie allanmckenzie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mapingo @coveralls @allanmckenzie