Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removal of event log trigger happening after database connections… #237

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

allanmckenzie
Copy link
Member

… destroyed

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

75.0% 75.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1867

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 91.19%

Changes Missing Coverage Covered Lines Changed/Added Lines %
event-store-management/event-store-management-command-handler-extension/src/main/java/uk/gov/justice/services/eventstore/management/trigger/TriggerRemovalServletContextListener.java 3 4 75.0%
Totals Coverage Status
Change from base Build 1865: -0.02%
Covered Lines: 3095
Relevant Lines: 3394

💛 - Coveralls

@allanmckenzie allanmckenzie merged commit 95f15d6 into master Aug 28, 2020
@allanmckenzie allanmckenzie deleted the fix-removal-of-event-log-trigger branch August 28, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants