Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename linked_event table to published_event and update all java names #82

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

allanmckenzie
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Apr 12, 2019

Pull Request Test Coverage Report for Build 679

  • 46 of 59 (77.97%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 88.946%

Changes Missing Coverage Covered Lines Changed/Added Lines %
event-sourcing/event-publisher/published-event-processor/src/main/java/uk/gov/justice/services/eventsourcing/publishedevent/PublishedEventSQLException.java 2 4 50.0%
event-sourcing/event-repository/event-repository-jdbc/src/main/java/uk/gov/justice/services/eventsourcing/repository/jdbc/event/PublishedEvent.java 0 11 0.0%
Totals Coverage Status
Change from base Build 674: 0.5%
Covered Lines: 1891
Relevant Lines: 2126

💛 - Coveralls

@@ -4,7 +4,7 @@
xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.3.xsd">

<changeSet id="event-store-010" author="TechPod"
<changeSet id="event-store-018" author="TechPod"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't this make the change set have a different file signature
we should add the trick here to say this is an acceptable change

@mapingo mapingo merged commit 81d4e21 into master Apr 12, 2019
@mapingo mapingo deleted the rename-linked-events branch April 12, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants