Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify datasource usage and setup #85

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Simplify datasource usage and setup #85

merged 1 commit into from
Apr 17, 2019

Conversation

allanmckenzie
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Apr 16, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 735

  • 96 of 105 (91.43%) changed or added relevant lines in 24 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 89.079%
Changes Missing Coverage Covered Lines Changed/Added Lines %
test-utils-event-store/test-utils-persistence/src/main/java/uk/gov/justice/services/test/utils/persistence/OpenEjbEventStoreDataSourceProvider.java 0 2 0.0%
event-sourcing/event-repository/event-repository-jdbc/src/main/java/uk/gov/justice/services/eventsourcing/repository/jdbc/event/EventJdbcRepository.java 19 22 86.36%
event-sourcing/event-repository/event-repository-jdbc/src/main/java/uk/gov/justice/services/eventsourcing/repository/jdbc/eventstream/EventStreamJdbcRepository.java 10 14 71.43%
Totals Coverage Status
Change from base Build 713: 0.03%
Covered Lines: 1925
Relevant Lines: 2161
💛 - Coveralls

@allanmckenzie allanmckenzie force-pushed the the-big-datasource-refactor branch 4 times, most recently from 3fee3e0 to b7e4037 Compare April 16, 2019 11:04
@mapingo mapingo force-pushed the the-big-datasource-refactor branch from b7e4037 to ca0dce5 Compare April 16, 2019 12:37
@allanmckenzie allanmckenzie force-pushed the the-big-datasource-refactor branch 2 times, most recently from 90c9957 to 5084535 Compare April 17, 2019 10:33
@mapingo mapingo force-pushed the the-big-datasource-refactor branch from 5084535 to 8912b20 Compare April 17, 2019 11:27
@allanmckenzie allanmckenzie merged commit 3713c0d into master Apr 17, 2019
@allanmckenzie allanmckenzie deleted the the-big-datasource-refactor branch April 17, 2019 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapingo mapingo mapingo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@allanmckenzie @coveralls @mapingo