Merge c88864d into 30b01b2

CHANGELOG.md

@@ -5,6 +5,10 @@ on [Keep a CHANGELOG](http://keepachangelog.com/). This project adheres to
 
 ## [Unreleased]
 
+## [2.4.1] - 2019-11-20
+### Fixed
+- Successful runs of a command now logs the success message from the server
+
 ## [2.4.0] - 2019-11-13
 ### Changed
 - Update to framework 6.4.0

src/main/java/uk/gov/justice/framework/command/client/jmx/CommandChecker.java

@@ -37,6 +37,8 @@ public boolean commandComplete(final SystemCommanderMBean systemCommanderMBean,
             final ZonedDateTime endTime = clock.now();
             final long durationMillis = between(startTime, endTime).toMillis();
 
+            toConsolePrinter.println(commandStatus.getMessage());
+
             final String duration = formatDuration(durationMillis, "HH:mm:ss");
             toConsolePrinter.println(format("Command %s complete", commandStatus.getSystemCommandName()));
             toConsolePrinter.println(format("%s duration %s (hours:minutes:seconds)", commandStatus.getSystemCommandName(), duration));

src/test/java/uk/gov/justice/framework/command/client/jmx/CommandCheckerTest.java

@@ -42,6 +42,7 @@ public class CommandCheckerTest {
     public void shouldLogAndReturnTrueIfTheCommandIsComplete() throws Exception {
 
         final UUID commandId = randomUUID();
+        final String message = "Woo hoo it worked";
 
         final ZonedDateTime startTime = new UtcClock().now();
         final ZonedDateTime endedAt = startTime.plusMinutes(83);
@@ -53,15 +54,17 @@ public void shouldLogAndReturnTrueIfTheCommandIsComplete() throws Exception {
         when(systemCommanderMBean.getCommandStatus(commandId)).thenReturn(systemCommandStatus);
         when(systemCommandStatus.getCommandState()).thenReturn(COMMAND_COMPLETE);
         when(systemCommandStatus.getSystemCommandName()).thenReturn("CATCHUP");
+        when(systemCommandStatus.getMessage()).thenReturn(message);
 
         assertThat(commandChecker.commandComplete(systemCommanderMBean, commandId, startTime), is(true));
 
+        verify(toConsolePrinter).println(message);
         verify(toConsolePrinter).println("Command CATCHUP complete");
         verify(toConsolePrinter).println("CATCHUP duration 01:23:00 (hours:minutes:seconds)");
     }
 
     @Test
-    public void shouldLogAndThrowExceptionfTheCommandFails() throws Exception {
+    public void shouldLogAndThrowExceptionIfTheCommandFails() throws Exception {
 
         final UUID commandId = randomUUID();