Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve integration tests #38

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Improve integration tests #38

merged 1 commit into from
Jun 4, 2018

Conversation

allanmckenzie
Copy link
Member

No description provided.

try {
return objectMapper.readValue(payload, User.class);
} catch (final IOException e) {
throw new RuntimeException(format("Failed to create User from json: '%s'", payload));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Define and throw a dedicated exception instead of using a generic one. rule

@cjs-common-platform-ci
Copy link
Member

SonarQube analysis reported 1 issue

  • MAJOR 1 major

Watch the comments in this conversation to review them.

@coveralls
Copy link

coveralls commented Jun 4, 2018

Coverage Status

Coverage remained the same at 93.631% when pulling 59826e7 on improve-integation-test into b4d42e2 on master.

@allanmckenzie allanmckenzie force-pushed the improve-integation-test branch 5 times, most recently from edd56a5 to 767d58c Compare June 4, 2018 10:46
@mapingo mapingo merged commit a164e6f into master Jun 4, 2018
@mapingo mapingo deleted the improve-integation-test branch June 4, 2018 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants