This repository has been archived by the owner on May 26, 2020. It is now read-only.
Handle source and classpath directory #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenNzewi
force-pushed
the
handle-source-and-classpath-dir
branch
from
bdf01e0
to
5853e8a
Compare
mapingo
suggested changes
Jul 9, 2018
|
|
||
|
|
||
| public void testShouldIncludeRamlFilesWhenSourcePathOrClassPathSpecified() throws Exception { | ||
| File pom = getTestFile("src/test/resources/generate-using-source-and-classpath/pom.xml"); |
| public void testShouldIncludeRamlFilesWhenSourcePathOrClassPathSpecified() throws Exception { | ||
| File pom = getTestFile("src/test/resources/generate-using-source-and-classpath/pom.xml"); | ||
|
|
||
| GenerateMojo mojo = (GenerateMojo) lookupConfiguredMojo(pom, "generate"); |
| GenerateMojo mojo = (GenerateMojo) lookupConfiguredMojo(pom, "generate"); | ||
|
|
||
| mojo.execute(); | ||
| List<Pair<Raml, GeneratorConfig>> capturedGeneratorArgs = DummyGeneratorCaptor.getInstance().capturedArgs(); |
|
|
||
| assertThat(capturedGeneratorArgs.size(), greaterThan(5)); | ||
|
|
||
| Raml raml = capturedGeneratorArgs.get(0).getLeft(); |
| Raml raml = capturedGeneratorArgs.get(0).getLeft(); | ||
| assertThat(raml.getTitle(), equalTo("example.raml")); | ||
|
|
||
| Path expectedSourceDirectory = Paths.get(project.getBasedir().toString(), "src", "raml"); |
| <skip.schema.pojo.generation>true</skip.schema.pojo.generation> | ||
| <skip.schema.event.pojo.generation>true</skip.schema.event.pojo.generation> | ||
| <useSourcePathAndClassPath>true</useSourcePathAndClassPath> | ||
| <useClassPath>false</useClassPath>--> |
There was a problem hiding this comment.
can this commented section be removed?
| private boolean useSourcePathAndClassPath = false; | ||
|
|
||
| @Parameter(property = "useClassPath", defaultValue = "false") | ||
| private boolean useClassPath = false; |
There was a problem hiding this comment.
Can this be an enumeration rather than two booleans?
BenNzewi
force-pushed
the
handle-source-and-classpath-dir
branch
9 times, most recently
from
f174900
to
22e0a80
Compare
BenNzewi
force-pushed
the
handle-source-and-classpath-dir
branch
from
22e0a80
to
bf9afda
Compare
mapingo
approved these changes
Jul 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.