This repository has been archived by the owner on May 26, 2020. It is now read-only.
Referenced schema resolver #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenNzewi
force-pushed
the
referenced-schema-resolver
branch
2 times, most recently
from
526aa26
to
7f1e478
Compare
mapingo
suggested changes
Jul 2, 2018
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(CatalogUpdater.class); | ||
|
|
||
| public void updtateRawCatalog(Map<String, String> schemaIdsToRawJsonSchemaCache, Path basePath, Collection<Path> paths) { |
There was a problem hiding this comment.
the method arguments can be final
| return ofNullable(schemaIdsToRawJsonSchemaCache.get(schemaId)); | ||
| } | ||
|
|
||
| public void updateCatalogSchemaCache(final Path basePath, final Collection<Path> paths) { |
There was a problem hiding this comment.
There needs to be a test for this method
| public class CatalogUpdaterTest { | ||
|
|
||
| /*@Mock | ||
| private Logger logger;*/ |
| @InjectMocks | ||
| private RawCatalog rawCatalog; | ||
|
|
||
| @InjectMocks private CatalogUpdater catalogUpdater; |
There was a problem hiding this comment.
private CatalogUpdater catalogUpdater; could be on a separate line
| schemaIdsToRawJsonSchemaCache.put("http://justice.gov.uk/standards/address.json", "json schema" ); | ||
|
|
||
| rawCatalog.initialize(); | ||
| Collection<Path> paths = new ArrayList<>(); |
| schemaIdsToRawJsonSchemaCache.put("http://justice.gov.uk/standards/address.json", "json schema" ); | ||
|
|
||
| rawCatalog.initialize(); | ||
| Collection<Path> paths = new ArrayList<>(); |
| schemaIdsToRawJsonSchemaCache.put("http://justice.gov.uk/standards/address.json", "json schema"); | ||
|
|
||
| rawCatalog.initialize(); | ||
| Collection<Path> paths = new ArrayList<>(); |
BenNzewi
force-pushed
the
referenced-schema-resolver
branch
2 times, most recently
from
67e6970
to
7d77967
Compare
mapingo
approved these changes
Jul 2, 2018
BenNzewi
force-pushed
the
referenced-schema-resolver
branch
from
7d77967
to
48d2ae4
Compare
BenNzewi
force-pushed
the
referenced-schema-resolver
branch
from
48d2ae4
to
429bb8b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.