This repository has been archived by the owner on May 26, 2020. It is now read-only.
Fix duplicate key exception for class path catalog loader. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapingo
suggested changes
Aug 9, 2018
| @@ -44,7 +44,7 @@ public ClasspathCatalogLoader(final ObjectMapper objectMapper, | |||
| */ | |||
| public Map<URI, Catalog> getCatalogs() { | |||
| return listAllCatalogsFromClasspath().stream() | |||
| .collect(toMap(urlConverter::toUri, this::loadCatalog)); | |||
| .collect(toMap(urlConverter::toUri, this::loadCatalog, (c1, c2) -> c1)); | |||
There was a problem hiding this comment.
could the function be called something to make it clear what is going on here
| @@ -78,4 +80,22 @@ public void shouldThrowExceptionIfLoadingResourcesThrowsIOException() throws Exc | |||
|
|
|||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| public void shouldNotThrowExceptionIgDuplicateKeyAdded() throws Exception { | |||
There was a problem hiding this comment.
ExceptionIg shopuld be ExceptionIf
MartinYSpasov
force-pushed
the
fix-duplicate-key-exception
branch
from
f7c58eb
to
28b4b46
Compare
MartinYSpasov
force-pushed
the
fix-duplicate-key-exception
branch
from
28b4b46
to
c3b78e5
Compare
mapingo
approved these changes
Aug 9, 2018
mapingo
approved these changes
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.