This repository has been archived by the owner on May 26, 2020. It is now read-only.
TP-960: Surfacing the file name and location responsible for breaking the POJO generation process #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-rich
reviewed
Feb 15, 2019
catalog-core/src/main/java/uk/gov/justice/schema/catalog/CatalogUpdater.java
Outdated
Show resolved
Hide resolved
matt-rich
approved these changes
Feb 15, 2019
mapingo
approved these changes
Feb 15, 2019
| final String id = jsonObject.getString("id"); | ||
| schemaIdsToRawJsonSchemaCache.put(id, schema); | ||
| } | ||
| } catch (JsonParsingException e) { |
There was a problem hiding this comment.
minor...but JsonParsingException e could be final
catalog-core/src/test/java/uk/gov/justice/schema/catalog/util/CatalogUpdaterTest.java
Outdated
Show resolved
Hide resolved
maheshsubramanian
force-pushed
the
dev/tp-960
branch
from
c1d3a22
to
28ba945
Compare
… the POJO generation process
maheshsubramanian
force-pushed
the
dev/tp-960
branch
from
28ba945
to
6b9513f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.