This repository has been archived by the owner on May 26, 2020. It is now read-only.
Add integer enum support. #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinYSpasov
force-pushed
the
add-integer-enum-support
branch
from
c3d881f
to
741a666
Compare
mapingo
suggested changes
Jul 26, 2018
| @@ -71,7 +77,7 @@ private MethodSpec buildToStringMethod() { | |||
| .addAnnotation(Override.class) | |||
| .addModifiers(PUBLIC) | |||
| .returns(String.class) | |||
| .addStatement("return $L", VALUE_VARIABLE_NAME) | |||
| .addStatement("return $L", isNumericEnum ? "String.valueOf(".concat(VALUE_VARIABLE_NAME).concat(")") : VALUE_VARIABLE_NAME) | |||
There was a problem hiding this comment.
this looks quite complicated for an inline switch...it might be better as a method that returns a CodeBlock according to the switch and added using .addCode method
MartinYSpasov
force-pushed
the
add-integer-enum-support
branch
from
741a666
to
8760257
Compare
mapingo
approved these changes
Jul 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.