Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive events #10

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Archive events #10

merged 1 commit into from
Jun 1, 2018

Conversation

purple52
Copy link
Contributor

No description provided.

*/
boolean isApplicable(final JsonEnvelope event);
default TransformAction actionFor(final JsonEnvelope event) {
return isApplicable(event) ? TRANSFORM : NO_ACTION;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Remove this use of "isApplicable"; it is deprecated. rule

@coveralls
Copy link

coveralls commented May 31, 2018

Coverage Status

Coverage increased (+0.6%) to 83.682% when pulling d541e85 on archive-events into 2d18d1f on master.


import uk.gov.justice.services.core.enveloper.Enveloper;
import uk.gov.justice.services.eventsourcing.repository.jdbc.eventstream.EventStreamJdbcRepository;
import uk.gov.justice.services.eventsourcing.source.core.EventSource;
import uk.gov.justice.services.eventsourcing.source.core.EventStream;
import uk.gov.justice.services.eventsourcing.source.core.exception.EventStreamException;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Remove this unused import 'uk.gov.justice.services.eventsourcing.source.core.exception.EventStreamException'. rule

* The default implementation is false
*/
@Deprecated
default boolean isApplicable(final JsonEnvelope event){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INFO Do not forget to remove this deprecated code someday. rule

@cjs-common-platform-ci
Copy link
Member

SonarQube analysis reported 3 issues

  • MINOR 2 minor
  • INFO 1 info

Watch the comments in this conversation to review them.

@purple52 purple52 merged commit 853e1ac into master Jun 1, 2018
@purple52 purple52 deleted the archive-events branch June 1, 2018 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants