Add setStreamId method to EventTransformation to support transformations for new streams #17
+1,307
−643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,34 +25,30 @@ | |||
| * @deprecated use DEACTIVATE instead | |||
| */ | |||
| @Deprecated | |||
| public static final Action ARCHIVE = new Action(false, true, false, false); | |||
| public static final Action ARCHIVE = new Action(false, true, false); | |||
There was a problem hiding this comment.
MartinYSpasov
force-pushed
the
stream-id-fix
branch
2 times, most recently
from
20c4985
to
336f8a4
Compare
MartinYSpasov
force-pushed
the
stream-id-fix
branch
2 times, most recently
from
aef7505
to
8e6a8e1
Compare
mapingo
reviewed
Oct 17, 2018
| // public Optional<UUID> setStreamId(final JsonEnvelope event) { | ||
| // return Optional.of(STREAM_ID); | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Can this commented out code be removed?
MartinYSpasov
force-pushed
the
stream-id-fix
branch
4 times, most recently
from
a4de397
to
611a045
Compare
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
MartinYSpasov
force-pushed
the
stream-id-fix
branch
3 times, most recently
from
c7e9027
to
75eb75d
Compare
mapingo
suggested changes
Oct 25, 2018
| final EventTransformationStreamIdFilter eventTransformationStreamIdFilter = new EventTransformationStreamIdFilter(); | ||
| final Optional<UUID> eventTransformationStreamId = eventTransformationStreamIdFilter.getEventTransformationStreamId(newHashSet(transformation1, transformation2), Arrays.asList(event1, event2)); | ||
|
|
||
| assertFalse(eventTransformationStreamId.isPresent()); |
There was a problem hiding this comment.
Is this correct? The test name seems to indicate that this would be true
…ons for new streams
MartinYSpasov
force-pushed
the
stream-id-fix
branch
from
70cf7b5
to
a989e19
Compare
mapingo
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.