archiving of existing events #9
Conversation
| when(event.metadata()).thenReturn(metadata); | ||
| when(event.metadata().name()).thenReturn("sample.archive.events.name"); | ||
|
|
||
| assertTrue(sampleTransformation.action(event)==ARCHIVE); |
There was a problem hiding this comment.
formatting around the == and in the other test.
| @@ -98,6 +107,12 @@ private boolean eventStoreTransformedEventPresent() throws SQLException { | |||
|
|
|||
| private void insertEventLogData() throws SQLException, InvalidSequenceIdException { | |||
There was a problem hiding this comment.
Not sure if it would be cleaner if we had a method to insert event for stream, at version with name. But this is ok.
There was a problem hiding this comment.
Done, refactored method to have parameters and removed added method.
| return false; | ||
| } | ||
|
|
||
| default TransformAction action(final JsonEnvelope event) { |
There was a problem hiding this comment.
java doc comments. Also update the deprecated comment to point to #action()
Is actionFor a better name than action ? (just asking the question, can discuss)
There was a problem hiding this comment.
updated java doc and renamed action method to actionFor
| @@ -17,15 +21,25 @@ | |||
| * @param event - the event to check | |||
| * @return TRUE if the event is eligible to have the transformation applied to it. | |||
There was a problem hiding this comment.
should probably update javadoc to mention default implementation is false also
|
|
||
| /** | ||
| * Transforms an events into zero to many events. | ||
| * | ||
| * @param event - the event to be transformed | ||
| * @return a stream of transformed events. | ||
| */ | ||
| Stream<JsonEnvelope> apply(final JsonEnvelope event); | ||
| default Stream<JsonEnvelope> apply(final JsonEnvelope event){ |
| final UUID clonedStreamId = eventSource.cloneStream(streamId); | ||
| switch (requiresTransformation(eventStream, streamId)) { | ||
| case TRANSFORM_EVENT: | ||
| return transformEvent(streamId, eventStream); |
There was a problem hiding this comment.
this should be transformStream not events?
This language is a little bit confusing because the way the requresTransformation returns a result for a stream but has an action based on an Event.
Maybe if we just name the action TRANSFORM ?
| @@ -104,15 +129,39 @@ private JsonEnvelope clearEventVersion(final JsonEnvelope event) { | |||
| ).flatMap(identity()); | |||
| } | |||
|
|
|||
| private boolean requiresTransformation(final Stream<JsonEnvelope> eventStream) { | |||
| return eventStream.filter(this::checkTransformations).count() > 0; | |||
| private TransformAction requiresTransformation(final Stream<JsonEnvelope> eventStream, UUID streamId) { | |||
| } | ||
|
|
||
| private UUID archiveStream(final UUID streamId, final Stream<JsonEnvelope> eventStream) throws EventStreamException { | ||
| eventStreamJdbcRepository.markActive(streamId,false); |
There was a problem hiding this comment.
formatting. space after comma
| stream.append(transformedEventStream.map(this::clearEventVersion)); | ||
| events.close(); | ||
| } catch (Exception e) { | ||
| logger.error("Failed to clone stream", e); |
There was a problem hiding this comment.
we need to say which stream id failed to clone
Is the only failure that can occur a clone? isn't the clone action just a small part of this?
There was a problem hiding this comment.
changed the logger statement to accept the stream Id parameter.
Not quite sure about the exception as this is an existing implementation and not changed as part of this work.
| .distinct() | ||
| .collect(Collectors.toList()); | ||
|
|
||
| if (eventTransformationList.size() == 0) { |
| return noAction(eventStream, streamId, "Stream {} did not require transformation stream "); | ||
| } | ||
| if (eventTransformationList.size() > 1) { | ||
| return noAction(eventStream, streamId, "Stream {} can not have multiple actions "); |
There was a problem hiding this comment.
would it be useful to log/return what the multiple actions were?
There was a problem hiding this comment.
Done. added in logger the multiple action names
|
|
||
| } | ||
|
|
||
| private TransformAction noAction(Stream<JsonEnvelope> eventStream, UUID streamId, String errorMessage) { |
No description provided.