This repository has been archived by the owner on May 26, 2020. It is now read-only.
configured object mapper to not fail if unexpected properties are found #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purple52
suggested changes
Jul 20, 2018
| @@ -275,7 +285,8 @@ public String toString() { | |||
| private final int age; | |||
| private final Colour favouriteColour; | |||
|
|
|||
| public Person(final String name, final int age, final Colour favouriteColour) { | |||
| @JsonCreator | |||
| public Person(@JsonProperty("name") final String name, @JsonProperty("age") final int age, @JsonProperty("favouriteColour") final Colour favouriteColour) { | |||
There was a problem hiding this comment.
We shouldn't need these annotations - in fact, adding them means that we are not testing that the object mapper works without them. If you're finding the tests fail withoout them when running from your IDE, ist probably because you haven't got the "-parameters" compiler option turned on.
|
|
||
| public PersonWithAdditionalProperties(final String name, final int age, final Map<String, Object> additionalProperties) { | ||
| @JsonCreator | ||
| public PersonWithAdditionalProperties(@JsonProperty("name") final String name, @JsonProperty("age") final int age, final Map<String, Object> additionalProperties) { |
purple52
force-pushed
the
tolerate-additional-properties
branch
from
a2f225a
to
c020d5c
Compare
purple52
approved these changes
Jul 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well...
Its practice now to set 'allowaddtionalProperties=true' in all our schemas. Unfortunately, the currently configured ObjectMapperProducer's configuration is not in accord with this policy.