This repository has been archived by the owner on May 26, 2020. It is now read-only.
add yaml parser #35
Merged
add yaml parser #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedFarouk-HMCTS
force-pushed
the
add-yaml-parser
branch
2 times, most recently
from
ebf67b2
to
2ea8fc1
Compare
mapingo
suggested changes
May 3, 2019
| import com.fasterxml.jackson.databind.PropertyNamingStrategy; | ||
| import com.fasterxml.jackson.dataformat.yaml.YAMLFactory; | ||
|
|
||
| public class ObjectMapperFactory { |
There was a problem hiding this comment.
This Class name should be clear about what this class does...maybe...YamlObjectMapperFactory
| import org.mockito.runners.MockitoJUnitRunner; | ||
|
|
||
| @RunWith(MockitoJUnitRunner.class) | ||
| public class YamlParserTest { |
There was a problem hiding this comment.
This test class is inconsistent. One test uses mocks, then the other tests switch to an implementation of the YamlParser. It should be one or the other or two different test classes for clarity.
| public class YamlParser { | ||
|
|
||
| @Inject | ||
| protected ObjectMapperFactory objectMapperFactory; |
|
|
||
| private YamlParser yamlParser() { | ||
| final YamlParser yamlParser = new YamlParser(); | ||
| yamlParser.objectMapperFactory = new ObjectMapperFactory(); |
There was a problem hiding this comment.
If the ObjectMapperFactory needs injecting use @SPY with mocking, or ReflectionUtils with a new instance. That way the injection can be private.
MohamedFarouk-HMCTS
force-pushed
the
add-yaml-parser
branch
from
2ea8fc1
to
02ddc82
Compare
mapingo
approved these changes
May 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.