fix: wrapper CacheSwitch with div to avoid error in React v16 - #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolve issue 19
|
@CJY0208 any better idea? |
|
感谢~ 目前的担忧是额外的 dom 节点可能会造成未知问题，查询 React 文档后没有找到绕过手段，所以 v15 中确实需要增加这个节点了 但 v16 中可以避免这个问题，所以我认为可以简单地用上一些兼容手段，必要时才添加包裹节点，且优先使用 |
|
@CJY0208 看看这么改如何 |
|
好的，十分感谢~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #19
Because React Components can return array since React v16, to avoid error when using
CacheSwitchComponent in React v16 - , need to handle the return array.