New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tc forecast max radius #68
Conversation
@manniepmkam Could you give this a look? |
This pull request looks all good to me apart from the unit conversion is still a bit unclear to me (see the above comments) |
@manniepmkam The "above comments" seem to have been dropped, at least I cannot see them. What do you mean by "unit conversion"? |
# Conflicts: # climada_petals/hazard/tc_tracks_forecast.py
@manniepmkam Can you give this another look? |
Yes I have checked again the unit conversion (line 496 in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, apart from some leftover commented code.
Delete leftover commented code Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
Thanks for the reviews @peanutfun and @manniepmkam. The last open change requested was now implemented: it was the removal of some commented lines and it was already preparded in a commit by @peanutfun. As this was a very small change, I now assume every thing is fine and I will merge this PR. |
This changes the functionality of generating a TCForecast fetched from ECMWF tropical cyclone forecasts stored in bufr files. It now fills the radius_max_wind attribute. It calculates that radius as the distance of the provided "location of maximum windspeed" from the storm center.
I am happy for a review.
Best,
Thomas