Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MultiPolygon with MultiPolygon.geoms for Iterability #80

Merged
merged 5 commits into from Jun 6, 2023
Merged

Replace MultiPolygon with MultiPolygon.geoms for Iterability #80

merged 5 commits into from Jun 6, 2023

Conversation

emanuel-schmid
Copy link
Contributor

@emanuel-schmid emanuel-schmid commented Jun 2, 2023 •
edited

Changes proposed in this PR:

  • Since shapely 2.0, MultiPolygons are not iterable anymore. therefore this PR suggests to use their geoms attribute as arguments when we the raster is set in from_nc.

This PR fixes #79

PR Author Checklist

PR Reviewer Checklist

@emanuel-schmid emanuel-schmid changed the title river_flood.from_nc: in case of MultiPolygon, use multi_polygon.geoms Replace MultiPolygon with MultiPolygon.geoms for Iterability Jun 2, 2023
@emanuel-schmid emanuel-schmid added bug Something isn't working dependencies Problems arising from imported libraries or their versions labels Jun 2, 2023
@emanuel-schmid emanuel-schmid self-assigned this Jun 2, 2023
@tovogt
Copy link
Collaborator

tovogt commented Jun 5, 2023 •
edited

Thanks! I took the opportunity to refactor the from_nc code, removing the calls to set_raster.

@tovogt @emanuel-schmid
Update climada_petals/hazard/river_flood.py
94187ec 
Co-authored-by: Emanuel Schmid <51439563+emanuel-schmid@users.noreply.github.com>
@emanuel-schmid
Copy link
Contributor Author

Thanks! I took the opportunity to refactor the from_nc code, removing the calls to set_raster.

🤩

@emanuel-schmid emanuel-schmid merged commit fae4326 into develop Jun 6, 2023
4 checks passed
@emanuel-schmid emanuel-schmid deleted the feature/fix_79 branch June 6, 2023 15:55
@peanutfun peanutfun mentioned this pull request Sep 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tovogt tovogt Awaiting requested review from tovogt

Assignees

@emanuel-schmid emanuel-schmid

Labels
bug Something isn't working dependencies Problems arising from imported libraries or their versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emanuel-schmid @tovogt