-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elevation package #9
Comments
All dependencies from elevation have been removed from the master branch. |
Opened an issue on the elevation package repository concerning the "I'm sorry the tools has been design to work on Linux/MacOS/Unix and I never tested it on Windows. It may work using the Windows Subsystem for Linux (WSL), but it is not supported." "You might consider filing a bug with windows that it is not implementing the -p option which is required by POSIX: https://pubs.opengroup.org/onlinepubs/9699919799/ While that seems hard, it would probably make a lot of things work better on Windows if it were fixed." |
WSL is not really an option, because
I agree on your adjustment that filing a bug report to Windows will lead nowhere. (I even wonder whether that suggestion was actually sarcastic.) Which leaves 3 options:
|
A more sophisticated tc_surge model is being developed which does not rely on the elevation package. Furthermore, surge models are very sensitive to the local geometry (elevation). Hence, it may be better to not provide generic elevation data, and instead, require the user to provide such data. Suggestion: remove the elevation package from the requirements and archive the current tc_surge module. |
The elevation package is used by the climada.hazard.tc_surge module and also imported in methods of climada.util and climada.hazard.centroid.
As for now, this package can be well installed on a Windows computer through pip. But it will not work, not in version 1.0.6 in any case.
The reason why it doesn't work is that in the background it basically runs bash or bash commands.
find
mkdir
from UnxUtils won't work because option-p
is ignored, but can easily be implemented. However there seems to be no waymkdir
from Windows can be overridden (probably because it is an "internal command").Bottomline: elevation must be adapted to work for Windows. Alternatively we relinquish its use and switch to another package or simply implement the required functionality.
The text was updated successfully, but these errors were encountered: