Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/move unittest #732

Merged
merged 5 commits into from
Jun 13, 2023
Merged

Feature/move unittest #732

merged 5 commits into from
Jun 13, 2023

Conversation

NicolasColombi
Copy link
Collaborator

@NicolasColombi NicolasColombi commented Jun 2, 2023

Changes proposed in this PR:

Move lazy unittest to the integration folder.

List of tests moved:

  • climada/engine/test/test_impact_data/test_emdat_damage_yearlysum (~ 6 sec)
  • climada/engine/unsequa/test/test_unsequa/test_calc_uncertainty_pass (~ 4.5 sec)
  • climada/engine/unsequa/test/test_unsequa/test_plot_unc_cb (~ 3.5 sec)
  • climada/engine/test/test_impact_data/test_scale_impact2refyear (~ 4 sec)
  • climada/engine/test/test_impact_data/test_emdat_to_impact_scale (~ 7 sec)
  • climada/engine/unsequa/test/test_unsequa.py/test_calc_sensitivity_pass (~ 2.3 sec)

This PR decrease the cost of unittest by around 27s. All tests are placed in the integration folder in the new file test_engine.py, except for one plotting function which has his place in: test_plot.py

As a consequence of moving tests, 5 Pylint warnings are transfered from test_unsequa.py to test_plot.py

PR Author Checklist

PR Reviewer Checklist

@peanutfun
Copy link
Member

@NicolasColombi something is off here. You reverted your original commit, so there are no changes in this branch.

@peanutfun
Copy link
Member

The changes in the first commit look good and the tests are passing on my machine. I'll handle this and merge immediately, as it might clash with some changes introduced tomorrow.

@peanutfun peanutfun marked this pull request as ready for review June 13, 2023 15:05
@peanutfun peanutfun self-assigned this Jun 13, 2023
@peanutfun peanutfun merged commit 654f9cb into develop Jun 13, 2023
3 checks passed
@emanuel-schmid emanuel-schmid deleted the feature/move_unittest branch August 11, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants