New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/centroids as gdf #787
Conversation
I just wanted to drop here for reference the following point: Centroids coordinates used to be reliably in lat/lon coordinates (epsg4326). Or at least that's what I assumed. Now that they are in a GeoDataFrame with a "serious" crs attribute, we should probably make sure that none of the functions that use centroids just blindly assume that the |
# Conflicts: # climada/hazard/trop_cyclone.py
…fined dist_coast in centroids
Test and Unittests have been updated and complemented to about a coverage of 80%. Former tests in test_vec_ras.py have been incorporated into the test_centr.py mostly as they were, which still results in some doubling of testing ideas. |
# Conflicts: # CHANGELOG.md
…really _are_ failing now
This reverts commit d6d2859.
# Conflicts: # CHANGELOG.md
Changes proposed in this PR:
This is a DRAFT, and comments are welcome. Not all tests are already running through as many tests are using the centroids class even though they should not. But this will be fixed once we converge to a final result.This pull request is getting close to review-ready, pending some open discussion points (see below).
PR Author Checklist
develop
)PR Reviewer Checklist