fix yearsets.sample_from_poisson #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
chahank
reviewed
Dec 5, 2023
| if lam != 1: | ||
| events_per_year = np.round(np.random.poisson(lam=lam, | ||
| size=n_sampled_years)).astype('int') | ||
| else: | ||
| events_per_year = np.ones(len(n_sampled_years)) | ||
|
|
||
| return np.round(np.random.poisson(lam=lam, size=n_sampled_years)).astype('int') |
There was a problem hiding this comment.
I am not sure to understand. This changes the behaviour of the method. Is this desired?
There was a problem hiding this comment.
Yes, exactly. The original behavior at lam = 1.0 is inconsistent, see discussion in #820.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
yearsets.sample_from_poissonThis PR fixes #819
PR Author Checklist
develop)PR Reviewer Checklist