Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add impact.select reset_frequency option #847

Merged
merged 3 commits into from Jan 30, 2024
Merged

add impact.select reset_frequency option #847

merged 3 commits into from Jan 30, 2024

Conversation

timschmi95
Copy link
Collaborator

@timschmi95 timschmi95 commented Jan 26, 2024 •
edited

Changes proposed in this PR:

  • add a reset_frequency option in impact.select(), analogue to hazard.select()

This PR fixes #830

PR Author Checklist

PR Reviewer Checklist

@timschmi95
Copy link
Collaborator Author

@emanuel-schmid All tests are failing due to missing internet connection. Is this a temporary issue or do I need to change something?

@peanutfun
Copy link
Member

@timschmi95 An issue with the data API firewall. Will probably take until next week to be resolved

@emanuel-schmid
Copy link
Collaborator

emanuel-schmid commented Jan 29, 2024 •
edited

may still fail due to a problem with the installation environment but at least the firewall issue is solved

peanutfun
peanutfun requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@peanutfun peanutfun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this nice contribution! 🙌 I have a few minor suggestions.

climada/engine/test/test_impact.py Outdated Show resolved Hide resolved
climada/engine/impact.py Outdated Show resolved Hide resolved
climada/engine/impact.py Outdated Show resolved Hide resolved
peanutfun
peanutfun approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@peanutfun peanutfun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, @timschmi95 🎉

@peanutfun peanutfun merged commit d82827c into develop Jan 30, 2024
11 checks passed
@peanutfun peanutfun mentioned this pull request Jan 30, 2024
Closed
@peanutfun peanutfun deleted the feature/impact-reset-frequency branch January 31, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peanutfun peanutfun peanutfun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timschmi95 @peanutfun @emanuel-schmid