Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExistingFileValidator should also check for read permission #249

Open
rafiw opened this issue Mar 4, 2019 · 0 comments · May be fixed by #250
Open

ExistingFileValidator should also check for read permission #249

rafiw opened this issue Mar 4, 2019 · 0 comments · May be fixed by #250

Comments

@rafiw
Copy link
Contributor

rafiw commented Mar 4, 2019

Hi @henryiii ,
ExistingFileValidator doesn't check if file is readable, e.g no permission.
I think it should be added as a default, instead of adding a new validator for this check.
Another option is adding a parameter to the ExistingFileValidator to check read write and not only if exists.
what do you think?
rafiw pushed a commit to rafiw/CLI11 that referenced this issue Mar 4, 2019
add read and write file validators CLIUtils#249
48a9357
rafiw pushed a commit to rafiw/CLI11 that referenced this issue Mar 4, 2019
add read and write file validators CLIUtils#249
3ab8954 
Signed-off-by: Rafi Wiener <rafiw@mellanox.com>
rafiw pushed a commit to rafiw/CLI11 that referenced this issue Mar 4, 2019
add read and write file validators CLIUtils#249
6f88e6c 
Signed-off-by: Rafi Wiener <rafiw@mellanox.com>
@henryiii henryiii linked a pull request Mar 12, 2019 that will close this issue
Open
rafiw pushed a commit to rafiw/CLI11 that referenced this issue Mar 12, 2019
add read and write file validators CLIUtils#249
6be685b 
Signed-off-by: Rafi Wiener <rafiw@mellanox.com>
rafiw pushed a commit to rafiw/CLI11 that referenced this issue Mar 12, 2019
add read and write file validators CLIUtils#249
08012c7 
Signed-off-by: Rafi Wiener <rafiw@mellanox.com>
rafiw pushed a commit to rafiw/CLI11 that referenced this issue Mar 12, 2019
add read and write file validators CLIUtils#249
51e814b 
Signed-off-by: Rafi Wiener <rafiw@mellanox.com>
rafiw pushed a commit to rafiw/CLI11 that referenced this issue Mar 13, 2019
add read and write file validators CLIUtils#249
926fb4f 
Signed-off-by: Rafi Wiener <rafiw@mellanox.com>
rafiw pushed a commit to rafiw/CLI11 that referenced this issue Mar 18, 2019
add read and write file validators CLIUtils#249
8402e14 
Signed-off-by: Rafi Wiener <rafiw@mellanox.com>
henryiii pushed a commit to rafiw/CLI11 that referenced this issue May 16, 2019
@henryiii
add read and write file validators CLIUtils#249
a0c0e18 
Signed-off-by: Rafi Wiener <rafiw@mellanox.com>
rafiw pushed a commit to rafiw/CLI11 that referenced this issue Dec 7, 2019
@rafiw
add read and write file validators CLIUtils#249
66a3428 
Signed-off-by: Rafi Wiener <rafiw@mellanox.com>
rafiw pushed a commit to rafiw/CLI11 that referenced this issue Dec 7, 2019
@rafiw
add read and write file validators CLIUtils#249
bef2388 
Signed-off-by: Rafi Wiener <rafiw@mellanox.com>
Signed-off-by: Rafi Wiener <rafiwiener@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add read and write file validators #249 rafiw/CLI11
1 participant
@rafiw