Filedir checks #341
Merged
Filedir checks #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 3331 3337 +6
=====================================
+ Hits 3331 3337 +6
Continue to review full report at Codecov.
|
henryiii
approved these changes
Nov 25, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stems from an issue in our application about using an optional default ini file. That is sometimes present, but often not. In the current code this generated an internal exception that was caught but would clutter up trapping exceptions from other parts of the program and made debugging difficult in some cases.
This PR splits out the detection of the file and directory types into a separate function and uses that in a couple locations instead of using the Validators. This prevents any exception from being thrown for non-required config files.
Since I was working with that code anyway, I added the detection for C++17 and filesystem and the 64 bit operations on visual studio which should address #312.
use of <filesystem> can be turned off by defining CLI11_HAS_FILESYSTEM to 0