Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dot notation #789

Merged
merged 9 commits into from
Jan 4, 2023
Merged

feat: dot notation #789

merged 9 commits into from
Jan 4, 2023

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Oct 14, 2022

Add the ability to use subcommand options using . notation
--sub.option or nested subcommands using dot notation.

@phlptp
Copy link
Collaborator Author

phlptp commented Oct 14, 2022

Still likely need to add more tests and some documentation updates

@phlptp
Copy link
Collaborator Author

phlptp commented Oct 14, 2022

from discussion on gitter

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 99.29% // Head: 99.30% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e7be7e8) compared to base (9a6c6f6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   99.29%   99.30%           
=======================================
  Files          16       16           
  Lines        3974     4022   +48     
=======================================
+ Hits         3946     3994   +48     
  Misses         28       28           
Impacted Files Coverage Δ
include/CLI/App.hpp 100.00% <ø> (ø)
include/CLI/impl/App_inl.hpp 99.23% <100.00%> (+0.02%) ⬆️
include/CLI/impl/Split_inl.hpp 98.70% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phlptp phlptp force-pushed the dotNotation branch 2 times, most recently from 15a8614 to 2693b60 Compare October 17, 2022 13:43
@phlptp
Copy link
Collaborator Author

phlptp commented Oct 17, 2022

@henryiii I think this is ready now

@phlptp phlptp requested a review from henryiii October 24, 2022 03:19
@henryiii
Copy link
Collaborator

Is there a test for toml config with this? That was one of the reasons for it IIRC?

@henryiii henryiii changed the title Dot notation feat: dot notation Oct 28, 2022
@phlptp
Copy link
Collaborator Author

phlptp commented Nov 21, 2022

The toml processing of dot notation worked before and is tested in a few locations, so this just adds to the command line parsing and doesn't change anything in the file parsing.

@henryiii henryiii merged commit 4c7c8dd into CLIUtils:main Jan 4, 2023
@henryiii henryiii deleted the dotNotation branch January 4, 2023 15:05
@github-actions github-actions bot added the needs changelog Hasn't been added to the changelog yet label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs changelog Hasn't been added to the changelog yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants