Fix windows.h include #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ws applications. Or at least minimizes the potential conflicts
Codecov ReportBase: 99.45% // Head: 99.45% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 18 18
Lines 4069 4069
=======================================
Hits 4047 4047
Misses 22 22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
phlptp
force-pushed
the
fix_windows_includes
branch
from
b911e0f
to
a88dd9b
Compare
henryiii
approved these changes
Jan 21, 2023
github-actions
bot
added
needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #831 at least in my application.
The issue was the slimmed down include of windows.h worked well in most applications but if the code using CLI11 also included windows.h the slimmed down definitions conflicted and all sorts of chaos ensued. This wasn't an issue with the precompiled or static library editions of CLI but becomes a bigger issue with the single header include.
What this does is only include the actual required windows headers and not the outer wrapper for windows.h