chore: Mark include files as SYSTEM #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When including CLI11 in a separate project (e.g. via FetchContent) cmake will now mark the CLI11 include files as system includes, which prevents compilers from issuing any warnings for stuff it found inside these headers. This makes sure that downstream users are not confronted with potential warning messages from CLI11, regardless of what kind of obscure warnings they might have enabled for their projects. Fixes CLIUtils#833
phlptp
approved these changes
Feb 10, 2023
Codecov ReportBase: 99.45% // Head: 99.45% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 18 18
Lines 4069 4069
=======================================
Hits 4047 4047
Misses 22 22 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
github-actions
bot
added
needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When including CLI11 in a separate project (e.g. via FetchContent) cmake will now mark the CLI11 include files as system includes, which prevents compilers from issuing any warnings for stuff it found inside these headers. This makes sure that downstream users are not confronted with potential warning messages from CLI11, regardless of what kind of obscure warnings they might have enabled for their projects.
Fixes #833