Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env validation #926

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Env validation #926

merged 1 commit into from
Oct 6, 2023

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Sep 23, 2023

Fixes #925

@phlptp
Copy link
Collaborator Author

phlptp commented Sep 23, 2023

The environmental variable results must now pass any existing validators to be included. This resolves an issue where help could not be reached.

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
include/CLI/impl/App_inl.hpp 100.00%

📢 Thoughts on this report? Let us know!.

@phlptp phlptp force-pushed the env_validation branch 2 times, most recently from bd9cebb to ac85d00 Compare September 24, 2023 00:42
add automatic validation to environmental variables
@phlptp phlptp merged commit ff1ec84 into CLIUtils:main Oct 6, 2023
50 checks passed
@phlptp phlptp deleted the env_validation branch October 6, 2023 15:37
@github-actions github-actions bot added the needs changelog Hasn't been added to the changelog yet label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog Hasn't been added to the changelog yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Displaying the help should take precedence over checking env vars & other possible checks
2 participants