Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TV import files now reset old mappings #314

Merged
merged 5 commits into from Sep 3, 2019
Merged

Conversation

simonreed
Copy link
Contributor

Addresses #238

TV imports now remove old mappings when importing a new txt file.

@coveralls
Copy link

coveralls commented Aug 19, 2019

Coverage Status

Coverage increased (+3.4%) to 81.468% when pulling 9bb64bb on feature/238-tv-import into 5bec349 on develop.

@spuddybike
Copy link
Member

tests are failing - not sure if this was intended?

@simonreed
Copy link
Contributor Author

Not intended but i'm aware. Moving this to a work in progress.

@simonreed simonreed changed the title TV import files now reset old mappings WIP: TV import files now reset old mappings Aug 20, 2019
@spuddybike spuddybike assigned simonreed and unassigned spuddybike Aug 20, 2019
@simonreed
Copy link
Contributor Author

I've removed the Redis records for Cluster and Strand. This means the mappings with topic conflicts are all handled by the PG database.

I've also added the UI changes so that you can now see the topic conflicts when on the dataset show page you try to :

  1. Assign a question that already has a set topic which conflicts
  2. Set a topic for the variable if you already have a resolved topic (from an assigned question)

314_set_topic_for_variable

When importing files for either TV or DV mappings you can now view the progress and logs for the imports. This will show you if the import has run successfully and if it fails where it failed/succeed on a line by line basis.

image

image

image

@simonreed simonreed changed the title WIP: TV import files now reset old mappings TV import files now reset old mappings Sep 2, 2019
@spuddybike spuddybike merged commit 70a33f0 into develop Sep 3, 2019
@spuddybike spuddybike deleted the feature/238-tv-import branch April 25, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants