Vertical layout #109
Closed
Vertical layout #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is still a work in progress - it works, but the margins aren't quite right (I need to figure out where and how to reallocate margins for captions and titles, and also figure out what to do in the case where there is a missing title or a missing caption, as the margins don't work as well there. It's functional but not ready for distribution yet.
This solves some of the problems. But, we will still want to eliminate the extra margins when there is no title or caption. We could also look to clean up and simiplify the code, since it's a bit of copy and paste right now - more of a proof of concept than final code.
added 3 commits
February 1, 2021 13:11
Had a call to layout_style before it was match.arg'ed.
|
So, I assume this should be closed in favor of #111? |
|
Yes, that makes sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to have a vertical layout. It's not done, and in particular, I just got an error message when running a chart with nothing in the
layout_styleargument, which I'll need to look into. But it (mostly) works.