-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
finalize w/ systemfonts & ragg #130
Conversation
Merge branch 'version1.2' of https://github.com/CMAP-REPOS/cmapplot into v1.2finalize # Conflicts: # R/finalize_plot.R
- remove bmp as save type option - change to ragg for raster export - change to svglite for svg export
Merge branch 'v1.2finalize' of https://github.com/CMAP-REPOS/cmapplot into v1.2finalizewfonts # Conflicts: # DESCRIPTION # NAMESPACE # R/cmapplot.R
- spell out raster types again
…nto v1.2finalizewfonts
@sarahcmap, one thought is whether the svglite package is up to date on your machine? Presumably the package was updated to use systemfonts at some point relatively recently. In fact, we may want to require a certain version of that package, presuming older versions don't handle fonts correctly and new ones do? |
Incorporates Noel's suggestion.
For now, use `svg` instead of `svglite`.
OK. @matthewstern and I think that at this stage, it might make sense to move ahead and use the original I will create a consolidated issue for a future enhancement to shift from @sarahcmap since you've been working on this, are you OK with that approach? @nmpeterson , any concerns from you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amused that I can't "approve" a PR that I opened, but this looks good to me. I'll do more testing on the larger 1.2 branch once this is merged in, but all the code changes seem fine to me.
Thanks @dlcomeaux and @matthewstern for troubleshooting! I think your plan sounds fine Daniel. |
I'm creating a PR as draft for @sarahcmap's work on updating
finalize_plot()
to work with ragg. Work isn't done yet, but with multiple potential contributors at this point, this will be useful to track what's still to do. The goal is to get plot finalization working with ragg, svglite, and systemfonts. See #127 for context.Sarah wrote on 5/4 in teams:
I able to remove
mode = "window"
and related code, but didn't get to look at svg outputs.