remove unused race categories from legend

[leotorres114]

Decided to try to implement Noel's first approach from Issue 142, which seems a bit more intuitive to the end user, e.g. provide which race categories are available the data and cmap_fill_race() / cmap_color_race() should automatically exclude those not provided.

match.call() was used because cmap_fill/color_race is passing all of its arguments to make_race_palette, which uses that list of arguments to build the palette. if match.call() wasn't used, the arguments passed to make_race_palette would be unevaluated symbol class (better explained here), which wouldn't allow make_race_palette to build a palette from the arguments passed to it. Most resources pointed to the need to use match.call() for this scenario, but maybe there's a better way to address this?

do.call() is just executing the make_race_palette with a list of the arguments (names and values) provided to cmap_fill/color_race().

To build the palette, make_race_palette loops through the names of race_palette - if that name is included in the names of the argument list passed, it adds the argument list value of passed as the index and hex value of race_palette as the value to an empty character vector, pal.

[dlcomeaux]

When the code is done, please also update documentation (using the RStudio tools to do that, Ctrl + Shift + D should do the trick) and make any necessary updates to the vignettes. Thanks!

[dlcomeaux]

And, we'll want to update the version number and note the changes in News.md

[leotorres114]

@dlcomeaux documentation, vignettes, and News.md have been updated accordingly. Let me know if you have any thoughts about my reply to your comment above.

[dlcomeaux]

@dlcomeaux documentation, vignettes, and News.md have been updated accordingly. Let me know if you have any thoughts about my reply to your comment above.

Sorry for the very long delay. This solution works, and I agree, seems more trouble than it's worth to go after a more complex solution.

[dlcomeaux]

@leotorres114 this works, I will update documentation and merge.

[dlcomeaux]

@EthanJantz @amcadamsCMAP question for you - this is failing in the pkgdown part of the run, with an error that I don't recognize. Are either of you familiar with what might cause this?

[leotorres114]

@dlcomeaux it looks like the gh actions workflow file is outdated. it can't find r-lib/actions@master because it's been updated (reference). I created another PR to update the workflow file, #145 , with the correct version. updating that first should (hopefully) take care of that error.